Use MetaIssuers to simulate EKS / GKE in e2e test. #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
changed the title
mattmoor
force-pushed
the
test-meta-path
branch
4 times, most recently
from
1ca7f2d
to
b8d7a81
Compare
Add dropped LRU initialization (oops merge conflict). Signed-off-by: Matt Moore <mattomata@gmail.com>
mattmoor
force-pushed
the
test-meta-path
branch
from
b8d7a81
to
b82aa0d
Compare
|
This is RFAL. Sorry @bobcallaway merged my last PR too fast 🏎️ , I'd wanted to add this there (and this fixes a bug) |
mattmoor
commented
Oct 28, 2021
Comment on lines
+236
to
+240
| cache, err := lru.New2Q(100 /* size */) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| cfg.lru = cache |
There was a problem hiding this comment.
This is the bug. It got lost in a merge conflict 😞
dlorenc
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matt Moore mattomata@gmail.com
Release Note