Remove viper from pkg/.
#257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bobcallaway I think the next thing I'm going to chase after |
dlorenc
approved these changes
Dec 2, 2021
This change moves the CA creating to the `serve` entrypoint, and attaches the appropriate `CertificateAuthority` to the request contexts. The same for the `ct-log-url`. With this change, all of the `viper` logic lives under `./cmd` and the logic in `./pkg` receives its configurations through parameters (possible attached to `ctx`). Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
mattmoor
force-pushed
the
be-gone-viper
branch
from
c13af88
to
d8c9656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change builds on #255. It moves the CA creating to the
serveentrypoint, and attaches the appropriateCertificateAuthorityto the request contexts. The same for thect-log-url.With this change, all of the
viperlogic lives under./cmdand the logic in./pkgreceives its configurations through parameters (possible attached toctx).Signed-off-by: Matt Moore mattmoor@chainguard.dev
WIP until the base change lands.
Ticket Link
N/A
Release Note