Wrap the server with the Prometheus so we get metrics + add an e2e te… #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st for it. I wrapped it in a job, since otherwise it will be trickier to get access to the metrics from outside the kind cluster. Fix the dangling pointer from sigstore#262 and fix a tiny typo, though I kind of do like exposing a singingCert that might come handy in karaoke? Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
lucky and hit the one that we didn't sign, so testing that. Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Remove debug cruft. Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
vaikas
added a commit
to vaikas/fulcio
that referenced
this pull request
Dec 8, 2021
…nto it. Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
lukehinds
requested changes
Dec 9, 2021
| }) | ||
| // Wrap the inner func with instrumentation to get latencies | ||
| // that get partitioned by 'code' and 'method'. | ||
| return promhttp.InstrumentHandlerDuration( |
There was a problem hiding this comment.
Will the decorate handler mean fulcio would still function correctly without a running Prometheus instance present?What would happen to requests in that scenario?
There was a problem hiding this comment.
The nice part of the prometheus model is that it's pull based - exposing metrics with no instance is safe and a noop. A running collector would be needed to actually scrape these and do something useful with them.
dlorenc
approved these changes
Dec 9, 2021
lukehinds
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap the server with the Prometheus so we get metrics + add an e2e test for it. Note that
the default prometheus metrics (go_*) were already exposed.
I wrapped test in a job, since otherwise it will be trickier to get access to the
metrics from outside the kind cluster.
Fix the dangling pointer from #262 and fix a tiny typo, though I kind of do
like exposing a singingCert that might come handy (should be required?) in karaoke?
Signed-off-by: Ville Aikas vaikas@chainguard.dev
Summary
Ticket Link
Fixes
Release Note