Enable server settings via config file and env vars #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
reviewed
Jan 5, 2022
jdolitsky
force-pushed
the
issue-314
branch
4 times, most recently
from
8d1d80b
to
95dc24b
Compare
Modify the viper settings in the serve subcommand to allow users to provide a config file using -c/--config vs. setting everything using command line flags. Sinc this is based upon viper, the following config file extensions are supported: "json", "toml", "yaml", "yml", "properties", "props", "prop", "hcl", "tfvars", "dotenv", "env", and "ini". This change also allows using env vars prefixed with FULCIO_SERVE to provide configuration settings as well. Resolves sigstore#314 Signed-off-by: Josh Dolitsky <josh@dolit.ski>
mattmoor
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the viper settings in the serve subcommand to allow users to provide a config file using -c/--config vs. setting everything using command line flags.
Sinc this is based upon viper, the following config file extensions are supported: "json", "toml", "yaml", "yml", "properties", "props", "prop", "hcl", "tfvars", "dotenv", "env", and "ini".
This change also allows using env vars prefixed with FULCIO_SERVE to provide configuration settings as well.
Resolves #314