Fix docker-compose dexidp startup #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was some change in the last year to use a non-root user for the Dex image. This causes permission issues when mounting files, since the non-root user cannot access the mount. The workaround is to run as root, which should be fine for development. See dexidp/dex#1649 Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
cpanato
reviewed
Jan 6, 2022
| @@ -47,6 +47,7 @@ services: | |||
| - ct_server | |||
| dex-idp: | |||
| image: dexidp/dex:v2.30.0 | |||
| user: root | |||
There was a problem hiding this comment.
what if we change the location of the config file to a tmp directory?
There was a problem hiding this comment.
I tried this out too, I get permission issues with any directory. For example, if I mount ./config/dex to /tmp, the default user can't access /tmp. When I shell into the image without mounting a file, I'm able to access /tmp though, so I assume this is from the docker process that mounts the directory overriding the directory permissions.
|
@mattmoor Could we get this merged? |
bobcallaway
approved these changes
Jan 10, 2022
|
I'm also curious if we can find a way to not need this (do we in prod?), but I'm unfamiliar with docker compose to be of any real help. |
|
In prod, we load the config in directly, i.e I'll look at making that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some change in the last year to use a non-root
user for the Dex image. This causes permission issues
when mounting files, since the non-root user cannot
access the mount. The workaround is to run as root,
which should be fine for development.
See dexidp/dex#1649
Signed-off-by: Hayden Blauzvern hblauzvern@google.com