Add some reasonable timeouts to API server #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this close all open connections, i.e. will this stop the connection to Trillian? Or should we also add a timeout for outbound connections? |
|
This is just for inbound API requests. Timeouts on the outbound requests to the CT log are controllered here and it seems are set to 30 seconds https://github.com/sigstore/fulcio/blob/main/pkg/ctl/ctl.go#L37 |
haydentherapper
approved these changes
Jan 20, 2022
|
LGTM but it hit a merge conflict with your other one! |
Fixes sigstore#336 Signed-off-by: Nathan Smith <nathan@nfsmith.ca>
nsmith5
force-pushed
the
server-timeouts
branch
from
d57dddf
to
dad96bd
Compare
|
Rebased on main and should be good to go now :) |
dlorenc
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a 1 minute hard coded read, header read, write and idle timeout. This helps prevents accidental or malicious connection exhaustion of the API server.
Implementation note
While simply setting
ReadTimeoutwould have set the header read and write timeouts to the same value, I think setting them explicitly helps inform the future code readers about the server behaviour in case they're unfamiliar with the behaviour ofhttp.Servertimeouts.Ticket Link
Fixes #336
Release Note