Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for V1 Fulcio cert #355

Merged
merged 1 commit into from Jan 28, 2022
Merged

Conversation

haydentherapper
Copy link
Contributor

Signed-off-by: Hayden Blauzvern hblauzvern@google.com

Summary

Ticket Link

Fixes

Release Note


Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think to add in the PR summary how you get the certificate, just for the records, and maybe for the next update someone that will do that and does not know, can do it.

thanks for this!!

@lukehinds
Copy link
Member

what do you think to add in the PR summary how you get the certificate, just for the records, and maybe for the next update someone that will do that and does not know, can do it.

thanks for this!!

That's actually a good idea and @haydentherapper has a very good handle on the TUF root setup. Any ideas on what might be a better way to show users how to get the root CA Hayden? I don't think we should really have it in a readme any more, it was fine when we were in early development, but not as excusable now.

@dlorenc dlorenc merged commit 5d3a4af into sigstore:main Jan 28, 2022
@lukehinds
Copy link
Member

@dlorenc I think this one was in review still, see @cpanato comment

@dlorenc
Copy link
Member

dlorenc commented Jan 28, 2022

@dlorenc I think this one was in review still, see @cpanato comment

Oh my mistake! my fingers went too fast here. The cert here is accurate but we'd probably be better off linking people to the canonical location which is here: https://github.com/sigstore/root-signing/blob/main/repository/repository/targets/fulcio_v1.crt.pem

@lukehinds
Copy link
Member

@dlorenc is it possible a user (visiting this repo) could validate the cert as a TUF target? I might not be using the right TUFism's here, but someone could verify the cert as part of the root signing verify operation that others did after the key signing party (or perhaps even a subset of the verification)?

@dlorenc
Copy link
Member

dlorenc commented Jan 28, 2022

Yeah - it's not trivial but it should be doable with a TUF client. @asraa might have that incantation handy.

@asraa
Copy link
Contributor

asraa commented Jan 28, 2022

Yeah - it's not trivial but it should be doable with a TUF client. @asraa might have that incantation handy.

I can update the README with these instructions! But you can use the go-tuf CLI to do the following

  1. Extract trusted root keys from, let's say, the embeded repository in a cosign checkout
$ go get github.com/theupdateframework/go-tuf/cmd/tuf
$ tuf -d $(COSIGN_DIR)/pkg/cosign/tuf/ root-keys > sigstore-root.json
  1. Init and get fulcio_v1.crt.pem.
$ go get github.com/theupdateframework/go-tuf/cmd/tuf-client
$ tuf-client init https://raw.githubusercontent.com/sigstore/root-signing/main/repository/repository/ sigstore-root.json
$ tuf-client get https://raw.githubusercontent.com/sigstore/root-signing/main/repository/repository/ fulcio_v1.crt.pem
-----BEGIN CERTIFICATE-----
MIIB9zCCAXygAwIBAgIUALZNAPFdxHPwjeDloDwyYChAO/4wCgYIKoZIzj0EAwMw
KjEVMBMGA1UEChMMc2lnc3RvcmUuZGV2MREwDwYDVQQDEwhzaWdzdG9yZTAeFw0y
MTEwMDcxMzU2NTlaFw0zMTEwMDUxMzU2NThaMCoxFTATBgNVBAoTDHNpZ3N0b3Jl
LmRldjERMA8GA1UEAxMIc2lnc3RvcmUwdjAQBgcqhkjOPQIBBgUrgQQAIgNiAAT7
XeFT4rb3PQGwS4IajtLk3/OlnpgangaBclYpsYBr5i+4ynB07ceb3LP0OIOZdxex
X69c5iVuyJRQ+Hz05yi+UF3uBWAlHpiS5sh0+H2GHE7SXrk1EC5m1Tr19L9gg92j
YzBhMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBRY
wB5fkUWlZql6zJChkyLQKsXF+jAfBgNVHSMEGDAWgBRYwB5fkUWlZql6zJChkyLQ
KsXF+jAKBggqhkjOPQQDAwNpADBmAjEAj1nHeXZp+13NWBNa+EDsDP8G1WWg1tCM
WP/WHPqpaVo0jhsweNFZgSs0eE7wYI4qAjEA2WB9ot98sIkoF3vZYdd3/VtWB5b9
TNMea7Ix/stJ5TfcLLeABLE4BNJOsQ4vnBHJ

@dlorenc
Copy link
Member

dlorenc commented Jan 28, 2022

Opened #360 to track fixing my mistake on the merge here and enhancing the docs! Sorry about that again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants