Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the the invalid CA error message actionable #356

Merged
merged 1 commit into from Jan 28, 2022

Conversation

tstromberg
Copy link
Contributor

Signed-off-by: Thomas Stromberg t+github@chainguard.dev

Summary

This PR improves the error message when an invalid --ca is provided by making it directly actionable. This lowers the friction for folks like me who are blindly pasting lines from the sigstore-the-hard-way doc.

When I first saw the error message, it did not occur to me that it referenced the --ca value versus an expected value within the key pair. Here is the example command-line to trigger the condition:

fulcio serve --config-path=fulcio-config.json --ca=fulcioca --hsm-caroot-id=1 --ct-log-url=http://localhost:6105/sigstore --host=0.0.0.0 --port=5000

Old output

FATAL app/serve.go:119 unknown CA: fulcioca

New output

FATAL app/serve.go:119 --ca=fulcioca is not a valid selection. Try: pkcs11ca, googleca, fileca, or ephemeralca

Release Note

NONE

Signed-off-by: Thomas Stromberg <t+github@chainguard.dev>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks

LGTM

@lukehinds lukehinds merged commit 882b239 into sigstore:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants