Address signingCert panic with the last-byte calculation of finalChainPEM #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Stromberg <t+github@stromberg.org>
nsmith5
reviewed
Feb 1, 2022
pkg/api/ca.go
Outdated
| @@ -213,7 +213,7 @@ func (a *api) signingCert(w http.ResponseWriter, req *http.Request) { | |||
| } | |||
| if len(finalChainPEM) > 0 { | |||
| fmt.Fprintf(&ret, "%s", finalChainPEM) | |||
| if finalPEM[len(finalChainPEM)-1] != '\n' { | |||
| if finalChainPEM[len(finalChainPEM)-1] != '\n' { | |||
There was a problem hiding this comment.
Nit: Perhaps this might be more clear if we'd written as
Suggested change
| if finalChainPEM[len(finalChainPEM)-1] != '\n' { | |
| if !strings.HasSuffix(string(finalChainPEM), "\n") { |
There was a problem hiding this comment.
Great idea. Done!
Signed-off-by: Thomas Stromberg <t+github@chainguard.dev>
nsmith5
approved these changes
Feb 1, 2022
haydentherapper
approved these changes
Feb 2, 2022
|
@bobcallaway @dlorenc - Not sure when the last Fulcio release was, but if it's been pushed after 10262db, we'll want to get this change in and pushed. |
dlorenc
approved these changes
Feb 2, 2022
Ack, deploying after this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Stromberg t+github@stromberg.org
Summary
Addresses a panic caused by the incorrect string being referred for a newline check.
This panic only occurs if finalPEM is shorter than finalChainPEM.
Ticket Link
Fixes #369
Release Note