Improve error messages returned by SigningCert #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Stromberg <t+github@stromberg.org>
tstromberg
force-pushed
the
better-errs
branch
from
eca41f2
to
b9f83b9
Compare
dlorenc
approved these changes
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Stromberg t+github@stromberg.org
Summary
This improves error messages returned by SigningCert, specifically adding the URL and status code when an unexpected response code occurs. Currently, if one accidentally points the Fulcio client at a non-Fulcio endpoint, the error message isn't very helpful; particularly when an empty HTTP response body is encountered.
Previous error message
retrieving cert:New error message
retrieving cert: POST http://localhost:5000/api/v1/signingCert returned 403 Forbidden: ""Ticket Link
Fixes #387
Release Note