Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract development documentation from README #410

Merged
merged 1 commit into from Feb 17, 2022
Merged

Extract development documentation from README #410

merged 1 commit into from Feb 17, 2022

Conversation

endorama
Copy link
Member

Part of #372

This PR extract the part related to building fulcio for development from README to it's own file in docs/ folder.

/cc @nsmith5

Signed-off-by: Edoardo Tenani <edoardo.tenani@pm.me>
@nsmith5
Copy link
Contributor

nsmith5 commented Feb 16, 2022

I like that this isn't in the README and more but it definitely needs so more work. Could we a link to the global sigstore contributor docs here https://github.com/sigstore/.github/blob/main/CONTRIBUTING.md to help folks get an idea of what contributing looks like.

@endorama
Copy link
Member Author

I checked that and when creating a new issue the global CONTRIBUTING file is provided as guide.
I actually thought of moving it to a CONTRIBUTING.md in the repo, but didn't want to override the global one.

I think having the global one suggested by GitHub and a specific developer docs is a decent trade off. It would make sense to link from this file to the global contributing policy, I'll add it.

@dlorenc dlorenc merged commit ab5823a into sigstore:main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants