Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing testing dependency #429

Merged
merged 1 commit into from Feb 23, 2022
Merged

Conversation

nsmith5
Copy link
Contributor

@nsmith5 nsmith5 commented Feb 23, 2022

From https://sigstore.slack.com/archives/C02K0T1LNPQ/p1645575739690499:

go test -v ./... fails on main for me, but I can't tell why this wasn't caught in CI 馃

$ go test -v ./...
go: github.com/sigstore/fulcio/pkg/oauthflow: package github.com/magiconair/properties/assert imported from implicitly required module; to add missing requirements, run:
  go get github.com/magiconair/properties/assert@v1.8.5

go mod tidy indeed generates a diff adding this dependency so I'll open a PR to add this, but I'm curious about why CI isn't having a bad time....

Release Notes

NONE

Signed-off-by: Nathan Smith <nathan@chainguard.dev>
@dlorenc dlorenc merged commit 38b9f41 into sigstore:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants