Fix certificate README typos #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
jspeed-meyers
changed the title
k4leung4
approved these changes
Mar 24, 2022
haydentherapper
approved these changes
Mar 25, 2022
| @@ -32,9 +32,9 @@ OIDC ID token. | |||
|
|
|||
| To authorize the token Fulcio must: | |||
|
|
|||
| - Use the issuer claim from the token to find the issuers OIDC discovery | |||
| - Use the issuer claim from the token to find the issuer's OIDC discovery | |||
There was a problem hiding this comment.
nit: This doesn't happen with each request, they're cached and fetched periodically.
| endpoint | ||
| - Download the issuers signing keys from the discovery endpoint | ||
| - Download the issuer's signing keys from the discovery endpoint |
There was a problem hiding this comment.
nit: issuer's verification keys, instead of signing
dlorenc
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor typos in docs. Will fix DCO if dorked up. 馃
Signed-off-by: John Speed Meyers jsmeyers@chainguard.dev