Add validation of public keys to prevent certifying weak keys #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #490 +/- ##
==========================================
+ Coverage 47.49% 47.97% +0.47%
==========================================
Files 14 14
Lines 1059 1063 +4
==========================================
+ Hits 503 510 +7
+ Misses 482 480 -2
+ Partials 74 73 -1
Continue to review full report at Codecov.
|
bobcallaway
approved these changes
Mar 29, 2022
|
Updated the release note. |
This adds checks for RSA, ECDSA and ED25519 (no-op) keys. This will prevent Fulcio from signing certificates for the following: * DSA keys * RSA keys that are smaller than 2048 or larger than 4096 * RSA keys with weak primes * ECDSA keys that aren't P256, P384, or P521 (P224 or custom curves) Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
haydentherapper
force-pushed
the
validate-key
branch
from
c59f4f9
to
d0a9f7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds checks for RSA, ECDSA and ED25519 (no-op) keys. This
will prevent Fulcio from signing certificates for the following:
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note