Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add changelog for v0.4.0 #530

Merged
merged 1 commit into from
Apr 23, 2022
Merged

add changelog for v0.4.0 #530

merged 1 commit into from
Apr 23, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Apr 19, 2022

Summary

  • add changelog for v0.4.0

Ticket Link

n/a

Release Note

NONE

@cpanato cpanato marked this pull request as draft April 19, 2022 14:33
@haydentherapper
Copy link
Contributor

Can we get #527 in first since this changes the grpc api?

@cpanato
Copy link
Member Author

cpanato commented Apr 19, 2022

Can we get #527 in first since this changes the grpc api?

yes sir! 😃

@k4leung4
Copy link
Contributor

Looks like #527 landed.
can we update the changelog with the #527 enhancement?

thanks

@cpanato
add changelog for v0.4.0
c90bec5 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Member Author

cpanato commented Apr 21, 2022

Looks like #527 landed. can we update the changelog with the #527 enhancement?

thanks

added! :)

@cpanato cpanato marked this pull request as ready for review April 21, 2022 07:54
@cpanato cpanato requested a review from dlorenc April 21, 2022 07:54
@cpanato
Copy link
Member Author

cpanato commented Apr 21, 2022

@k4leung4 @haydentherapper @dlorenc PTAL

k4leung4
k4leung4 approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@k4leung4 k4leung4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@cpanato
Copy link
Member Author

cpanato commented Apr 23, 2022

@dlorenc ping to merge this, i dont have permissions to merge

@dlorenc dlorenc merged commit 8874247 into sigstore:main Apr 23, 2022
@cpanato cpanato deleted the changelog branch April 23, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc dlorenc approved these changes

@haydentherapper haydentherapper haydentherapper approved these changes

@k4leung4 k4leung4 k4leung4 approved these changes

@bobcallaway bobcallaway Awaiting requested review from bobcallaway

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cpanato @haydentherapper @k4leung4 @dlorenc