Fix key usage for issued certificates #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key usage should be Digital Signature, not Key Cert Sign. The latter requires that isCA also be asserted. The certificate's key is only used to verify signatures, not certificates. Note that this does not affect the GCP CA. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
@cpanato - We're going to want to cut a release with this fix before rolling out the new CA to production. |
Codecov Report
@@ Coverage Diff @@
## main #549 +/- ##
=======================================
Coverage 35.47% 35.47%
=======================================
Files 18 18
Lines 1415 1415
=======================================
Hits 502 502
Misses 853 853
Partials 60 60
Continue to review full report at Codecov.
|
dlorenc
approved these changes
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key usage should be Digital Signature, not Key Cert Sign. The latter
requires that isCA also be asserted. The certificate's key is only used
to verify signatures, not certificates.
Note that this does not affect the GCP CA.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes #550
Release Note