Consume identity.Principal in CA abstraction
#570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsmith5
force-pushed
the
challengeresult-as-principal
branch
from
ea2b10e
to
e8b998e
Compare
|
@znewman01 for refactoring mentorship eyeballs 🙏🏻 |
nsmith5
commented
May 12, 2022
nsmith5
force-pushed
the
challengeresult-as-principal
branch
2 times, most recently
from
a1cf313
to
a1ca128
Compare
nsmith5
force-pushed
the
challengeresult-as-principal
branch
from
a1ca128
to
7c9db98
Compare
Modifies the CA abstraction to consume identity.Principal instead of challenges.ChallengeResult. Also implements the indentity.Principal methods for ChallengeResult. Signed-off-by: Nathan Smith <nathan@chainguard.dev>
nsmith5
force-pushed
the
challengeresult-as-principal
branch
from
7c9db98
to
380c64c
Compare
|
(Just cleaning up that merge conflict) |
haydentherapper
approved these changes
May 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #570 +/- ##
==========================================
- Coverage 44.29% 43.95% -0.35%
==========================================
Files 21 21
Lines 1517 1513 -4
==========================================
- Hits 672 665 -7
- Misses 771 777 +6
+ Partials 74 71 -3
Continue to review full report at Codecov.
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of #275, we'd like to move away from the
challenges.ChallengeResultdata structure and useidentity.Principalandidentity.Issuerinstead. This PR changes theca.CertificateAuthorityto consumeidentity.Principaland a public key instead ofchallenges.ChallengeResult.Ticket Link
Related to #275
Release Note