Correct SPIFFE trust domain checking #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #588 +/- ##
==========================================
+ Coverage 45.90% 46.30% +0.39%
==========================================
Files 21 21
Lines 1501 1501
==========================================
+ Hits 689 695 +6
+ Misses 740 736 -4
+ Partials 72 70 -2
Continue to review full report at Codecov.
|
haydentherapper
requested changes
May 16, 2022
nsmith5
force-pushed
the
fix-allowed-spiffe-id
branch
2 times, most recently
from
2973812
to
f96c3a8
Compare
|
The failing test is because you will need to update |
nsmith5
force-pushed
the
fix-allowed-spiffe-id
branch
from
f96c3a8
to
2b028e9
Compare
SPIFFE issuers must configure a trust domain. We no longer assume that the the trust domain has some implicit relationship with the OIDC issuer domain. Tokens with a mismatch in trust domain are rejected. Signed-off-by: Nathan Smith <nathan@chainguard.dev>
nsmith5
force-pushed
the
fix-allowed-spiffe-id
branch
from
2b028e9
to
5d9a4d1
Compare
|
Can you update the PR summary? |
dlorenc
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SPIFFE issuers must configure a trust domain. We no longer assume that
the the trust domain has some implicit relationship with the OIDC issuer
domain. Tokens with a mismatch in trust domain are rejected.
Release Note