Validate SPIFFE IDs and trust domains via library #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds extra enforcement that trust domains are valid on startup, and validates that SPIFFE IDs in tokens are also of a valid format. Comparison is now done via the library too. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
cc @nsmith5 |
Codecov Report
@@ Coverage Diff @@
## main #592 +/- ##
==========================================
+ Coverage 48.44% 49.11% +0.66%
==========================================
Files 21 21
Lines 1515 1523 +8
==========================================
+ Hits 734 748 +14
+ Misses 707 703 -4
+ Partials 74 72 -2
Continue to review full report at Codecov.
|
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
nsmith5
approved these changes
May 17, 2022
dlorenc
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds extra enforcement that trust domains are valid on startup, and
validates that SPIFFE IDs in tokens are also of a valid format.
Comparison is now done via the library too.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note