Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move github principal to its own package #599

Merged
merged 1 commit into from May 26, 2022

Conversation

nsmith5
Copy link
Contributor

@nsmith5 nsmith5 commented May 20, 2022

Remove github workflow logic from challenge result and put it in its own
package.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #599 (cc6b684) into main (00d7e66) will increase coverage by 6.47%.
The diff coverage is 89.06%.

@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   49.74%   56.21%   +6.47%     
==========================================
  Files          21       23       +2     
  Lines        1548     1569      +21     
==========================================
+ Hits          770      882     +112     
+ Misses        705      609      -96     
- Partials       73       78       +5     
Impacted Files Coverage Δ
pkg/challenges/challenges.go 51.94% <0.00%> (+9.77%) ⬆️
pkg/identity/github/principal.go 90.47% <90.47%> (ø)
pkg/ca/ephemeralca/ephemeral.go 70.00% <0.00%> (ø)
pkg/ca/fileca/load.go 68.96% <0.00%> (+10.34%) ⬆️
pkg/oauthflow/oidc.go 100.00% <0.00%> (+50.00%) ⬆️
pkg/ca/x509ca/common.go 60.52% <0.00%> (+60.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d7e66...cc6b684. Read the comment docs.

pkg/identity/github/principal.go Outdated Show resolved Hide resolved
pkg/identity/github/principal.go Outdated Show resolved Hide resolved
pkg/identity/github/principal.go Outdated Show resolved Hide resolved
pkg/identity/github/principal_test.go Outdated Show resolved Hide resolved
pkg/identity/github/principal_test.go Outdated Show resolved Hide resolved
@nsmith5 nsmith5 force-pushed the github-principal branch 3 times, most recently from b0304ad to 1921dcb Compare May 23, 2022 15:30
pkg/challenges/challenges.go Outdated Show resolved Hide resolved
Remove github workflow logic from challenge result and put it in its own
package.

Signed-off-by: Nathan Smith <nathan@chainguard.dev>
@dlorenc dlorenc merged commit 85372aa into sigstore:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants