Added additional tests for CA implementations and OIDC #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #602 +/- ##
==========================================
+ Coverage 49.74% 52.70% +2.96%
==========================================
Files 21 22 +1
Lines 1548 1588 +40
==========================================
+ Hits 770 837 +67
+ Misses 705 670 -35
- Partials 73 81 +8
Continue to review full report at Codecov.
|
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
dlorenc
previously approved these changes
May 20, 2022
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
Review dismissal is far more aggressive now. I thought it had some tolerance for small nits... |
Allstarbot yelled at me so I had to change the setting to dismiss everything :( |
dlorenc
approved these changes
May 20, 2022
|
It's not too much of a nuisance, I just wish there was some small tolerance for single line/few character changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note