Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move email principal to package #620

Merged
merged 1 commit into from May 31, 2022

Conversation

nsmith5
Copy link
Contributor

@nsmith5 nsmith5 commented May 26, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #620 (878a29d) into main (7022d19) will increase coverage by 0.71%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
+ Coverage   57.13%   57.84%   +0.71%     
==========================================
  Files          24       25       +1     
  Lines        1563     1568       +5     
==========================================
+ Hits          893      907      +14     
+ Misses        595      589       -6     
+ Partials       75       72       -3     
Impacted Files Coverage Δ
pkg/challenges/challenges.go 46.20% <0.00%> (-1.87%) ⬇️
pkg/identity/email/principal.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7022d19...878a29d. Read the comment docs.

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit

Signed-off-by: Nathan Smith <nathan@chainguard.dev>
@haydentherapper haydentherapper merged commit fa41bd9 into sigstore:main May 31, 2022
@nsmith5 nsmith5 deleted the email-principal branch May 31, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants