Make prometheus port configurable #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdolitsky
previously approved these changes
May 31, 2022
haydentherapper
previously approved these changes
May 31, 2022
cpanato
reviewed
May 31, 2022
cpanato
previously approved these changes
May 31, 2022
Signed-off-by: Nathan Smith <nathan@chainguard.dev>
nsmith5
dismissed stale reviews from cpanato, haydentherapper, and jdolitsky
via
27e050b
nsmith5
force-pushed
the
configurable-prom-port
branch
from
c347953
to
27e050b
Compare
haydentherapper
approved these changes
May 31, 2022
cpanato
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a flag to make the prometheus metrics port configurable and defaults the current hard coded 2112.
When folks run through the popular https://blog.chainguard.dev/sigstore-the-local-way/ they find that Fulcio and Rekor and both hardcoded to use 2112 for prom endpoint and the can't both run on local host without recompiling one or the other. This allows folks to supply a different port.
Release Note