Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final challenge result removal 馃帀 #626

Merged

Conversation

nsmith5
Copy link
Contributor

@nsmith5 nsmith5 commented May 31, 2022

Summary

  • Move uri principal into its own package
  • Move username principal into its own package
  • Finally remove challenge result code 馃帀

Signed-off-by: Nathan Smith <nathan@chainguard.dev>
@codecov-commenter
Copy link

Codecov Report

Merging #626 (1151108) into main (fa41bd9) will increase coverage by 1.04%.
The diff coverage is 93.15%.

@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
+ Coverage   59.86%   60.90%   +1.04%     
==========================================
  Files          26       28       +2     
  Lines        1582     1586       +4     
==========================================
+ Hits          947      966      +19     
+ Misses        558      548      -10     
+ Partials       77       72       -5     
Impacted Files Coverage 螖
pkg/challenges/challenges.go 40.90% <0.00%> (-19.46%) 猬囷笍
pkg/identity/uri/principal.go 92.68% <92.68%> (酶)
pkg/identity/username/principal.go 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update fa41bd9...1151108. Read the comment docs.

Signed-off-by: Nathan Smith <nathan@chainguard.dev>
@nsmith5 nsmith5 force-pushed the final-challenge-result-removal branch from 1151108 to 58d6331 Compare May 31, 2022 18:40
@haydentherapper haydentherapper merged commit 35b7117 into sigstore:main Jun 1, 2022
@nsmith5 nsmith5 deleted the final-challenge-result-removal branch June 1, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants