Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump sigstore to 1.3.0-b95fc0d #665

Closed
wants to merge 1 commit into from

Conversation

Dentrax
Copy link
Member

@Dentrax Dentrax commented Jun 29, 2022

Fixes #654

Signed-off-by: Furkan furkan.turkal@trendyol.com

Summary

Ticket Link

Fixes

Release Note

Fixed an issue where hashivault client throws panics during some type casting cases.

@Dentrax
Copy link
Member Author

Dentrax commented Jun 29, 2022

PTAL @haydentherapper

I ran $ make fulcio and some auto-generated protobuf files has changed so committed. Can you please confirm it's correct?

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #665 (5feff2d) into main (ee8e8f9) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
- Coverage   62.02%   61.85%   -0.18%     
==========================================
  Files          30       30              
  Lines        1717     1717              
==========================================
- Hits         1065     1062       -3     
- Misses        569      571       +2     
- Partials       83       84       +1     
Impacted Files Coverage Δ
pkg/ca/fileca/load.go 58.62% <0.00%> (-10.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee8e8f9...5feff2d. Read the comment docs.

@haydentherapper
Copy link
Contributor

Thanks, going to get #666 merged in first which should fix the build error.

@haydentherapper
Copy link
Contributor

Could you run make clean and make fulcio again?

Fixes sigstore#654

Signed-off-by: Furkan <furkan.turkal@trendyol.com>
@Dentrax
Copy link
Member Author

Dentrax commented Jun 30, 2022

Could you run make clean and make fulcio again?

Done

@haydentherapper
Copy link
Contributor

Can you try again, but pull from upstream first? It shouldn’t be updating the version used I believe.

@haydentherapper
Copy link
Contributor

Looks like you don't need to run make, #671.

@haydentherapper
Copy link
Contributor

Closing, updated in the other PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting panic during initialization hashivault
3 participants