Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS support to HTTP endpoint #670

Merged
merged 6 commits into from Jul 1, 2022
Merged

Conversation

bobcallaway
Copy link
Member

This is blocking interactive use of the swagger tool against our production instance.

During this process, I noticed we were still passing some Grpc information in HTTP response headers so this also squelches those.

Signed-off-by: Bob Callaway bcallaway@google.com

Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error in test parse "passthrough:///:\x00\x00\x00\x00\x00\x00\x00": net/url: invalid control character in URL

cmd/app/http.go Show resolved Hide resolved
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
cmd/app/http_test.go Show resolved Hide resolved
Signed-off-by: Bob Callaway <bcallaway@google.com>
@codecov-commenter
Copy link

Codecov Report

Merging #670 (cf60081) into main (21b6f72) will decrease coverage by 7.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
- Coverage   61.56%   54.44%   -7.12%     
==========================================
  Files          30       36       +6     
  Lines        1717     2228     +511     
==========================================
+ Hits         1057     1213     +156     
- Misses        575      923     +348     
- Partials       85       92       +7     
Impacted Files Coverage Δ
cmd/app/http.go 53.96% <100.00%> (ø)
cmd/app/createca.go 19.49% <0.00%> (ø)
cmd/app/version.go 31.81% <0.00%> (ø)
cmd/app/grpc.go 48.27% <0.00%> (ø)
cmd/app/serve.go 19.33% <0.00%> (ø)
cmd/app/root.go 44.44% <0.00%> (ø)
pkg/ca/fileca/watch.go 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b6f72...cf60081. Read the comment docs.

@bobcallaway bobcallaway merged commit 5a9480e into sigstore:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants