Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] docs/oidc: mark code blocks as JSON, minor syntax fixes #697

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

woodruffw
Copy link
Member

No functional changes. Just noticed that these code blocks were missing syntax highlighting while reading the docs.

Signed-off-by: William Woodruff william@trailofbits.com

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Copy link
Member Author

Oh, Codecov...

Run codecov/codecov-action@81cd2dc8148241f03f5839d295e000b8f761e378
==> linux OS detected
Error: certificate has expired
    at TLSSocket.onConnectSecure (node:_tls_wrap:1[5](https://github.com/sigstore/fulcio/runs/7435468531?check_suite_focus=true#step:8:6)30:34)
    at TLSSocket.emit (node:events:390:28)
    at TLSSocket._finishInit (node:_tls_wrap:944:8)
    at TLSWrap.ssl.onhandshakedone (node:_tls_wrap:[7](https://github.com/sigstore/fulcio/runs/7435468531?check_suite_focus=true#step:8:8)25:12)

@haydentherapper
Copy link
Contributor

Thanks! LGTM, just need to wait until codecov fixes its expired cert.

@codecov-commenter
Copy link

Codecov Report

Merging #697 (bcc9cc5) into main (91ddddd) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
- Coverage   54.57%   54.44%   -0.14%     
==========================================
  Files          36       36              
  Lines        2228     2228              
==========================================
- Hits         1216     1213       -3     
- Misses        921      923       +2     
- Partials       91       92       +1     
Impacted Files Coverage Δ
pkg/ca/fileca/load.go 58.62% <0.00%> (-10.35%) ⬇️

@haydentherapper haydentherapper merged commit c16b7fc into sigstore:main Jul 20, 2022
@woodruffw woodruffw deleted the ww/fenced-blocks-json branch July 20, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants