address Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cpanato <ctadeu@gmail.com>
|
@cpanato Is there an equivalent setting for the gRPC handler? |
i'm not aware, but we can check. UPDATE: i'm not sure, did not find anything, but I dont have much experience with grpc :/ |
cmd/app/serve.go
Outdated
| @@ -80,6 +80,7 @@ func newServeCmd() *cobra.Command { | |||
| cmd.Flags().String("grpc-host", "0.0.0.0", "The host on which to serve requests for GRPC") | |||
| cmd.Flags().String("grpc-port", "8081", "The port on which to serve requests for GRPC") | |||
| cmd.Flags().String("metrics-port", "2112", "The port on which to serve prometheus metrics endpoint") | |||
| cmd.Flags().Duration("read-header-timeout", 60*time.Second, "The time allowed to read the headers of the requests in seconds") | |||
There was a problem hiding this comment.
Is this too long, should it be ~10 seconds or less (not much in the headers besides an auth token)? I assume we have request timeouts that would trigger before this, though I'm not sure where those are configured (k8s?).
There was a problem hiding this comment.
nginx uses 60s by default
i will reduce that to 10
There was a problem hiding this comment.
done
we need to check what is the value we are setting on the nginx side (client_header_timeout)
…onfigured in the http.Server Signed-off-by: cpanato <ctadeu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Release Note