Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unix socket #739

Merged
merged 2 commits into from
Aug 20, 2022
Merged

Clean up unix socket #739

merged 2 commits into from
Aug 20, 2022

Commits on Aug 16, 2022

  1. Clean up unix socket

    On MacOS it seems subsequent attempts to bind to the abstract Unix
    socket fail without first explicitly removing it. This issue seems to be
    MacOS-specific as it doesn't occur on an Ubuntu VM (using `lima`).
    
    Fixes sigstore#738
    
    Signed-off-by: Paul Thomson <thomsonp83@gmail.com>
    pauldthomson committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    3b1856e View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Add condition around socket file removal

    MacOS doesn't have abstract unix domain sockets, and so creates a file
    in the local dir which isn't removed when the server stops (due to the
    handling of sockets beginning with '@')
    
    This file needs to be removed on subsequent runs otherwise there's a
    bind error
    
    Signed-off-by: Paul Thomson <thomsonp83@gmail.com>
    pauldthomson committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    5cd969c View commit details
    Browse the repository at this point in the history