Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to go1.19 #767

Merged
merged 1 commit into from Sep 20, 2022
Merged

upgrade to go1.19 #767

merged 1 commit into from Sep 20, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Aug 31, 2022

Summary

  • upgrade to go1.19

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Merging #767 (e77d2b7) into main (a0b8644) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #767   +/-   ##
=======================================
  Coverage   54.54%   54.54%           
=======================================
  Files          36       36           
  Lines        2275     2275           
=======================================
  Hits         1241     1241           
  Misses        942      942           
  Partials       92       92           
Impacted Files Coverage Δ
pkg/config/config.go 69.25% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cpanato
Copy link
Member Author

cpanato commented Aug 31, 2022

getting this error

2022-08-31T09:31:04.580156925Z stderr F {"severity":"fatal","ts":1661938264.5799956,"caller":"app/serve.go:221","message":"x509: certificate contains duplicate extensions","stacktrace":"github.com/sigstore/fulcio/cmd/app.runServeCmd\n\tgithub.com/sigstore/fulcio/cmd/app/serve.go:221\ngithub.com/spf13/cobra.(*Command).execute\n\tgithub.com/spf13/cobra@v1.5.0/command.go:876\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\tgithub.com/spf13/cobra@v1.5.0/command.go:990\ngithub.com/spf13/cobra.(*Command).Execute\n\tgithub.com/spf13/cobra@v1.5.0/command.go:918\ngithub.com/spf13/cobra.(*Command).ExecuteContext\n\tgithub.com/spf13/cobra@v1.5.0/command.go:911\ngithub.com/sigstore/fulcio/cmd/app.Execute\n\tgithub.com/sigstore/fulcio/cmd/app/root.go:37\nmain.main\n\tgithub.com/sigstore/fulcio/main.go:25\nruntime.main\n\truntime/proc.go:250"}

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm, the go.mod version had to be updated after this has been submitted?

@cpanato
Copy link
Member Author

cpanato commented Aug 31, 2022

To confirm, the go.mod version had to be updated after this has been submitted?

yes

@cpanato cpanato force-pushed the upgrade-go119 branch 5 times, most recently from bf54352 to fa264ac Compare September 10, 2022 19:47
@cpanato cpanato force-pushed the upgrade-go119 branch 3 times, most recently from 121adc3 to d5d8075 Compare September 20, 2022 09:03
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato marked this pull request as ready for review September 20, 2022 09:41
@cpanato
Copy link
Member Author

cpanato commented Sep 20, 2022

all green now PTAL @dlorenc @haydentherapper @bobcallaway

@haydentherapper haydentherapper merged commit e91f130 into sigstore:main Sep 20, 2022
@cpanato cpanato deleted the upgrade-go119 branch September 20, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants