Expose RPC options to set oidc auth creds for KMS #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
haydentherapper
approved these changes
Dec 21, 2022
Codecov Report
@@ Coverage Diff @@
## main #934 +/- ##
=======================================
Coverage 53.56% 53.56%
=======================================
Files 37 37
Lines 2326 2326
=======================================
Hits 1246 1246
Misses 988 988
Partials 92 92
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
wlynch
approved these changes
Dec 21, 2022
|
Thanks for the reviews 💪🏻 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I realized I needed to pass in some extra RPC options (e.g. OIDC Auth). This just exposes all the RPC options so that folks using this as a library can pass them in.
Release Note
Documentation