Add custom error logs when communicating with the CA backend #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
|
cc @priyawadhwa |
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
bobcallaway
reviewed
Jan 17, 2023
hectorj2f
requested review from
bobcallaway
and removed request for
haydentherapper
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
hectorj2f
force-pushed
the
improve_err_messages
branch
from
4a63827
to
c4a729f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hector Fernandez hector@chainguard.dev
Summary
We realized most of the errors returned the same error message (e.g. genericCAError) when communicating with the CA backend. I added few more error logs and new error types depending on the logic of the error statements.
Release Note
Documentation