Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitsign verify #241

Closed
wlynch opened this issue Feb 18, 2023 · 0 comments · Fixed by #262
Closed

gitsign verify #241

wlynch opened this issue Feb 18, 2023 · 0 comments · Fixed by #262
Labels
enhancement New feature or request
Milestone

Comments

@wlynch
Copy link
Member

wlynch commented Feb 18, 2023

Description

We should add a gitsign verify command that follows cosign verify. e.g.

gitsign verify --certificate-identity <email> --certificate-oidc-issuer <idp provider> <revision>

The current git commit-verify flow is somewhat limited in that it only verifies that the signature matches, not that the identity matches a certain IdP (see #104 (comment) for more discussion). We should add a separate subcommand that explicitly verifies a given identity + provider pair.

We'll look to see how we can additional verification configuration in the future to git verify-commit (some interesting discussions going on with TUF folks), but this gives us a short-term solution in the meantime.

@wlynch wlynch added the enhancement New feature or request label Feb 18, 2023
@wlynch wlynch added this to the v1.0.0 milestone Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant