Remove usage of getopt to fix release. #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be some conflict with goreleaser, getopt/v2, getopt/v1 (through an indirect dep). We wanted to move off of getopt anyway, so this is just a convenient excuse to make the change. Verified we can get past the build step with ```sh goreleaser release --skip-publish --rm-dist --debug --snapshot ``` so hopefully this is the last of it. Signed-off-by: Billy Lynch <billy@chainguard.dev>
cpanato
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There seems to be some conflict with goreleaser, getopt/v2, getopt/v1 (through an indirect dep). We wanted to move off of getopt anyway, so this is just a convenient excuse to make the change.
Verified we can get past the build step with
so hopefully this is the last of it.
Signed-off-by: Billy Lynch billy@chainguard.dev
Release Note
BREAKING CHANGE(only if you were building from head): Removes
-sflag from gitsign-credential-cache. Use--systemd-socket-activationinstead.Documentation
n/a