Some updates on CI, add new jobs and dependabot config #29
Conversation
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
| return nil, errors.Wrap(err, "failed to locate rekor entry") | ||
| } | ||
| claims = append(claims, NewClaim(ClaimLocatedRekorEntry, true)) | ||
|
|
||
| if err := rekor.Verify(ctx, tlog); err != nil { | ||
| claims = append(claims, NewClaim(ClaimValidatedRekorEntry, true)) |
There was a problem hiding this comment.
Whoops, this one should be false 😅
| @@ -97,15 +115,14 @@ func Verify(ctx context.Context, data, sig []byte) (*VerificationSummary, error) | |||
| // Parse signature | |||
| sd, err := cms.ParseSignedData(der) | |||
| if err != nil { | |||
| claims = append(claims, NewClaim(ClaimParsedSignature, false)) | |||
There was a problem hiding this comment.
I'd want to keep these in in some form - this is a signal to users for what failed during validation. e.g. we want to show something like:
Parsed Git signature: true
Validated Git signature: true
Located Rekor entry: false
so it's obvious what stage validation failed on.
If we don't put in failed claims, perhaps we can infer what failed from what's missing in the successful claims during rendering? Not sure - open to ideas!
There was a problem hiding this comment.
maybe i'm not seeing or i'm too dumb but if we have those claims and return that will not show up in any place
example of original code
certs, err := sd.GetCertificates()
if err != nil {
claims = append(claims, NewClaim(ClaimValidatedSignature, false))
return nil, errors.Wrap(err, "error getting signature certs")
}
so the claims is not used
to use that we should return that in the struct and then not return the nil
There was a problem hiding this comment.
d'oh! you're right - we should be populating the verification summary. This is fine for now then - I'll re-add the verification summary in another PR!
Summary
Ticket Link
n/a
Release Note