Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go-git based signer implementation. #454

Merged
merged 1 commit into from Feb 21, 2024
Merged

Conversation

wlynch
Copy link
Member

@wlynch wlynch commented Feb 21, 2024

Summary

Adds a git.Signer implementation + e2e test to demonstrate how signing is done. Verify still WIP upstream, so commit marshalling + verification still done manually for now.

Release Note

  • Added go-git compatible Signer.

Documentation

@wlynch wlynch force-pushed the gogit-signer branch 2 times, most recently from cb05eb9 to 51e47c7 Compare February 21, 2024 14:17
@wlynch wlynch force-pushed the gogit-signer branch 3 times, most recently from d4b1419 to 1475ad9 Compare February 21, 2024 14:24
Copy link

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, lgtm

Adds a git.Signer implementation + e2e test to demonstrate how signing
is done. Verify still WIP upstream, so commit marshalling + verification
still done manually for now.

Signed-off-by: Billy Lynch <billy@chainguard.dev>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@cpanato cpanato enabled auto-merge (squash) February 21, 2024 14:40
@cpanato cpanato merged commit 6f20ffd into sigstore:main Feb 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants