Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jupyter Notebook example for signing and verifying a model #170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

font
Copy link
Member

@font font commented May 11, 2024

Closes #169

Summary

Help make it easier to incorporate signing and verifying models into notebooks. To test, install Jupyter Notebook and run it locally inside the model_signing directory containing the notebook:

cd ./model-transparency/model_signing
jupyter notebook

Then open the sign_and_verify_model.ipynb notebook and execute it. Note that certain steps are interactive and the execution will halt at various cells waiting for input from the user.

Release Note

Documentation

@font font requested a review from a team as a code owner May 11, 2024 00:32
Signed-off-by: Ivan Font <ifont@redhat.com>
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and the issue.

I'll take a closer look, but overall, this looks like it extracts parts of the CLI code into notebook cells and makes the notebook be the driver for signing. Please correct me if I was wrong, I only skimmed through this right now.

We are working on making a library for signing so people don't need to copy code, just call an API.

@font
Copy link
Member Author

font commented May 28, 2024

Thank you for the PR and the issue.

I'll take a closer look, but overall, this looks like it extracts parts of the CLI code into notebook cells and makes the notebook be the driver for signing. Please correct me if I was wrong, I only skimmed through this right now.

Yes, that's correct!

We are working on making a library for signing so people don't need to copy code, just call an API.

Where is this work happening? Happy to help in any way I can.

@laurentsimon
Copy link
Collaborator

We are working on making a library for signing so people don't need to copy code, just call an API.

Where is this work happening? Happy to help in any way I can.

See #172 #188 and #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Jupyter Notebook to demonstrate signing and verifying a model
3 participants