-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log-level
flag to policy-tester, update output
#1414
Conversation
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1414 +/- ##
=======================================
Coverage 52.92% 52.92%
=======================================
Files 44 44
Lines 3979 3979
=======================================
Hits 2106 2106
Misses 1651 1651
Partials 222 222 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malancas Thanks for the PR!
@hectorj2f thanks for reviewing. Looks like there are few flaky test failures, would you mind rerunning them? |
@malancas Let me do it! |
Summary
When using
policy-tester
, I noticed the tool always output debug level logging. I added an optionallog-level
flag that will default to Info level logging. I also updated the Info level output to include logs indicating to the user what part of the verification process the tool was on.Old successful verification output:
New successful verification output using the default Info level logging:
Old failing verification output:
New failing verification output using the default Info level logging:
We can definitely keep iterating on the output as needed but I think this is a good start.
Release Note
Documentation