Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small logging updates #1501

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Small logging updates #1501

merged 1 commit into from
Jun 20, 2024

Conversation

malancas
Copy link
Contributor

Summary

I noticed some of the debug logs do not have newlines while others do. I added newlines to all of them for consistency. I also updated a debug log so instead of printing the entire attestation, it prints the attestation's digest. This seems easier to follow but let me know otherwise.

Release Note

Documentation

Signed-off-by: Meredith Lancaster <malancas@github.com>
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.28%. Comparing base (50ef092) to head (1c804b3).
Report is 111 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1501       +/-   ##
===========================================
- Coverage   52.92%   42.28%   -10.65%     
===========================================
  Files          44      121       +77     
  Lines        3979     7168     +3189     
===========================================
+ Hits         2106     3031      +925     
- Misses       1651     3783     +2132     
- Partials      222      354      +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpanato cpanato merged commit d8fee02 into sigstore:main Jun 20, 2024
71 of 72 checks passed
@github-actions github-actions bot added this to the v1 milestone Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants