Since by default we deny all, just drop it from CM. #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #282 +/- ##
=======================================
Coverage 62.41% 62.41%
=======================================
Files 28 28
Lines 2650 2650
=======================================
Hits 1654 1654
Misses 910 910
Partials 86 86 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mattmoor
approved these changes
Oct 1, 2022
There was a problem hiding this comment.
I want to make sure my explanation made sense to @hectorj2f, but this LGTM fwiw.
dlorenc
approved these changes
Oct 1, 2022
hectorj2f
approved these changes
Oct 1, 2022
|
Thanks @mattmoor, it makes sense ;). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ville Aikas vaikas@chainguard.dev
Summary
As per the comments, this is taking out the redundant
denyfrom the configmap which might make upgraders harder, asper:
#279 (comment)
@mattmoor
Release Note
Documentation