Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose webhook validator getters #449

Merged
merged 1 commit into from Dec 16, 2022

Conversation

joshrwolf
Copy link
Contributor

Summary

This PR exposes the webhook validator Getters for downstream consumers:

  • GetIncludeTypeMeta
  • GetIncludeObjectMeta
  • GetIncludeSpec

Release Note

Documentation

Signed-off-by: Josh Wolf <josh@wolfs.io>
Copy link
Collaborator

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov-commenter
Copy link

Codecov Report

Merging #449 (207f4bd) into main (a802bcd) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage   53.88%   53.88%           
=======================================
  Files          38       38           
  Lines        3799     3799           
=======================================
  Hits         2047     2047           
  Misses       1607     1607           
  Partials      145      145           
Impacted Files Coverage Δ
pkg/webhook/validator.go 65.72% <66.66%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vaikas vaikas merged commit b9e4b97 into sigstore:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants