Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If TLog.url is specified, use it if trustroot does not have one + test. #461

Merged
merged 1 commit into from Dec 21, 2022

Conversation

vaikas
Copy link
Collaborator

@vaikas vaikas commented Dec 20, 2022

Signed-off-by: Ville Aikas vaikas@chainguard.dev

Summary

  • If a trustroot is specified, and has keys but does not have URL there use the one from the TLog.URL entry. Also add a test for validating that an entry has been uploaded to Rekor.

Release Note

Documentation

…test.

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@codecov-commenter
Copy link

Codecov Report

Merging #461 (70e386b) into main (77e766f) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   55.57%   55.52%   -0.06%     
==========================================
  Files          38       38              
  Lines        3953     3957       +4     
==========================================
  Hits         2197     2197              
- Misses       1589     1592       +3     
- Partials      167      168       +1     
Impacted Files Coverage Δ
pkg/webhook/validator.go 65.46% <0.00%> (-0.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We asume any tlog to be a Rekor log. Should we document it somewhere? It is clear to me, just saying.

@vaikas
Copy link
Collaborator Author

vaikas commented Dec 21, 2022

We asume any tlog to be a Rekor log. Should we document it somewhere? It is clear to me, just saying.

Yeah, so for this, I think our next version of the API will clear these up I reckon with the namings. I'll document it more thoroughly in follow ups.

@vaikas vaikas merged commit e0d304b into sigstore:main Dec 21, 2022
@vaikas vaikas deleted the test-rekor-upload branch December 21, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants