chore: Relax certificate authority validation in trustRoots #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #471 +/- ##
=======================================
Coverage 55.66% 55.66%
=======================================
Files 38 38
Lines 3992 3992
=======================================
Hits 2222 2222
Misses 1598 1598
Partials 172 172
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dlorenc
approved these changes
Dec 25, 2022
cpanato
approved these changes
Dec 25, 2022
vaikas
reviewed
Jan 4, 2023
| @@ -99,8 +99,8 @@ func (remote *Remote) Validate(ctx context.Context) (errors *apis.FieldError) { | |||
| } | |||
|
|
|||
| func (sigstoreKeys *SigstoreKeys) Validate(ctx context.Context) (errors *apis.FieldError) { | |||
| if len(sigstoreKeys.CertificateAuthorities) == 0 { | |||
| errors = errors.Also(apis.ErrMissingField("certificateAuthority")) | |||
| if len(sigstoreKeys.CertificateAuthorities) == 0 && len(sigstoreKeys.TimeStampAuthorities) == 0 { | |||
There was a problem hiding this comment.
FYI, we also need to update that assumption here when we're pulling things from TUF repos / remotes once we add support for getting TSA keys from there:
https://github.com/sigstore/policy-controller/blob/main/pkg/reconciler/trustroot/trustroot.go#L248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We could create a TrustRoot with a list of TSAs servers without defining any additional CA.
Release Note
Documentation