Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional Message to Static actions for custom fail message. #652

Merged
merged 1 commit into from Mar 8, 2023

Conversation

vaikas
Copy link
Collaborator

@vaikas vaikas commented Mar 8, 2023

Summary

For Static actions, they currently just say which CIP failed. To make the error message more actionable, add an optional Message field that then could contain suggestions for corrective actions.

Release Note

  • Add Message to static actions for more descriptive error messages.

Documentation

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #652 (4f2d853) into main (7b24e83) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
+ Coverage   55.33%   55.37%   +0.03%     
==========================================
  Files          45       45              
  Lines        4787     4791       +4     
==========================================
+ Hits         2649     2653       +4     
  Misses       1934     1934              
  Partials      204      204              
Impacted Files Coverage Δ
...g/apis/policy/v1alpha1/clusterimagepolicy_types.go 0.00% <ø> (ø)
...kg/apis/policy/v1beta1/clusterimagepolicy_types.go 0.00% <ø> (ø)
...s/policy/v1alpha1/clusterimagepolicy_conversion.go 76.19% <100.00%> (+0.38%) ⬆️
pkg/webhook/validator.go 62.80% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vaikas vaikas merged commit c847d20 into sigstore:main Mar 8, 2023
@vaikas vaikas deleted the custom-static-msg branch March 8, 2023 19:22
@github-actions github-actions bot added this to the v1 milestone Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants