Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor entire policy validation into ValidatePolicy. #81

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

vaikas
Copy link
Collaborator

@vaikas vaikas commented Jul 13, 2022

Signed-off-by: Ville Aikas vaikas@chainguard.dev

Summary

Refactor the ValidatePolicy that includes the CIP level policy validation. This makes for example, cmd/tester validate the entire CIP.

Release Note

Documentation

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@codecov-commenter
Copy link

Codecov Report

Merging #81 (cb0287e) into main (a05dad8) will decrease coverage by 0.02%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   58.94%   58.91%   -0.03%     
==========================================
  Files          21       21              
  Lines        2097     2091       -6     
==========================================
- Hits         1236     1232       -4     
+ Misses        799      798       -1     
+ Partials       62       61       -1     
Impacted Files Coverage Δ
pkg/webhook/validator.go 78.27% <72.72%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a05dad8...cb0287e. Read the comment docs.

@vaikas vaikas changed the title [WIP]: Refactor entire policy validation into ValidatePolicy. Refactor entire policy validation into ValidatePolicy. Jul 13, 2022
Copy link
Collaborator

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hectorj2f hectorj2f merged commit 5902a64 into sigstore:main Jul 14, 2022
@vaikas vaikas deleted the validate-policy-all branch July 14, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants