jsonschema: container fix, updated compilation options #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleightcap
force-pushed
the
jl/jsonschema
branch
from
4fd0d68
to
97d6c37
Compare
Signed-off-by: Jack Leightcap <jack.leightcap@trailofbits.com>
jleightcap
force-pushed
the
jl/jsonschema
branch
from
e33eec0
to
6492e36
Compare
woodruffw
reviewed
Aug 3, 2023
Dockerfile.jsonschema
Outdated
| @@ -1,6 +1,6 @@ | |||
| # 3.18.2 | |||
| FROM alpine@sha256:82d1e9d7ed48a7523bdebc18cf6290bdb97b82302a8a9c27d4fe885949ea94d1 | |||
| RUN apk add --update protoc=3.21.12-r2 protobuf-dev=3.21.12-r2 go=1.20.5-r0 git=2.40.1-r0 | |||
| RUN apk add --update protoc=3.21.12-r2 protobuf-dev=3.21.12-r2 go=1.20.7-r0 git=2.40.1-r0 | |||
There was a problem hiding this comment.
CC @znewman01 for consensus, but I'd personally be okay with removing these pins now that we understand how they interact with the surrounding alpine image: the image itself has a "world" pin that effectively pins each of these dependencies.
(In other words, the pins here are extraneous and only cause trouble when the alpine image is updated automatically and they aren't.)
There was a problem hiding this comment.
Ahhh okay. That makes me a little nervous about auto-updates of the image itself. But I guess any big changes due to updates would get caught by the generation tests.
So I say go ahead and remove
woodruffw
previously approved these changes
Aug 3, 2023
woodruffw
reviewed
Aug 3, 2023
Signed-off-by: William Woodruff <william@yossarian.net>
znewman01
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #120, towards #118
Release Note
Documentation