Include CloudEvents proto to generated bundle #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2023
jalseth
force-pushed
the
ce-proto
branch
2 times, most recently
from
7cf33af
to
a92b206
Compare
bobcallaway
reviewed
Jul 25, 2023
jalseth
force-pushed
the
ce-proto
branch
2 times, most recently
from
fca72ca
to
eba30ba
Compare
bobcallaway
previously approved these changes
Jul 28, 2023
|
Not sure why the check failed. I used |
|
Have you rebased against main, before running |
Sigstore will follow the CloudEvents specification when publishing events to Pub/Sub topics. Signed-off-by: James Alseth <james@jalseth.me>
|
Oh, thanks! I didn't realize 20+ commits had been made since I opened this. Should be fixed now. |
haydentherapper
approved these changes
Jul 31, 2023
|
Thanks @jalseth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sigstore will follow the CloudEvents specification when publishing events to Pub/Sub topics. Protobuf events can be used for better efficiency compared to JSON.
Release Note
Documentation
N/A, all docs on events usage will be included in the relevant project (rekor, rekor-monitor, etc.).