Use ruby_package proto option #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the Ruby module names generated from the proto files by using the `option ruby_package=`. Setting these allows for more idiomatic Ruby class naming within the namespace `Sigstore::`. Signed-off-by: Paul Welch <pwelch@github.com>
Signed-off-by: Paul Welch <pwelch@github.com>
Regenerate proto files by using `make all` after updating Ruby class names. Signed-off-by: Paul Welch <pwelch@github.com>
haydentherapper
approved these changes
Jul 10, 2023
@haydentherapper Agreed. I assumed only the Ruby generated code would need to be updated but it looks like it updates something in several of the generated files? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the Ruby module names generated from the proto files by using the
option ruby_package=. Setting these allows for more idiomatic Ruby class naming within the namespaceSigstore::.Release Note
Sigstore::namespace now. Please reference the generated Ruby files for the new class names.Documentation