Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy encrypted cosign key #1446

Merged
merged 1 commit into from Apr 23, 2023
Merged

Conversation

bobcallaway
Copy link
Member

We are now using Fulcio-based ephemeral keys to sign rekor releases, so deleting the encrypted private key and Makefile target.

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested review from cpanato and a team as code owners April 23, 2023 09:38
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #1446 (7dc16a7) into main (fb50ad8) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1446      +/-   ##
==========================================
- Coverage   64.32%   64.28%   -0.05%     
==========================================
  Files          82       82              
  Lines        7874     7873       -1     
==========================================
- Hits         5065     5061       -4     
- Misses       2161     2163       +2     
- Partials      648      649       +1     
Flag Coverage Δ
e2etests 47.68% <ø> (-0.01%) ⬇️
unittests 43.14% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@cpanato cpanato merged commit e289057 into sigstore:main Apr 23, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.1.0 milestone Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants