Refactor Trillian client with exported methods #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the Trillian client to be used in other parts of the codebase besides the api package. The changes included exporting the Response fields and all but one of the struct methods. Also removed ranges since these weren't used outside the api package. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
Context is starting work on creating a stable checkpoint, where a goroutine outside of the api package will periodically fetch the latest checkpoint. |
Codecov Report
@@ Coverage Diff @@
## main #1454 +/- ##
==========================================
- Coverage 64.35% 64.31% -0.05%
==========================================
Files 82 82
Lines 7873 7864 -9
==========================================
- Hits 5067 5058 -9
Misses 2159 2159
Partials 647 647
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Moved to draft because I'm not certain I need this yet. |
|
Ready for review! |
bobcallaway
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the Trillian client to be used in other parts of the codebase besides the api package. The changes included exporting the Response fields and all but one of the struct methods. Also removed ranges since these weren't used outside the api package.
Summary
Release Note
Documentation